-
-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mealplan improvements without the scrolling overhaul #2497
Mealplan improvements without the scrolling overhaul #2497
Conversation
Fixes mealie-recipes#2256 Also fixed some minor type warnings that were coming up
TODO: Have this configurable in the .env, but for now it's set to hour 0
3d36cfd
to
ce35e3f
Compare
@@ -19,7 +19,8 @@ | |||
|
|||
|
|||
def create_mealplan_timeline_events(group_id: UUID4 | None = None): | |||
event_time = datetime.now(timezone.utc) | |||
# Move it back by 1 minute to ensure that midnight processing logs it to the prev day |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this following a precedent set somewhere else?
Personally I consider 00:00:00 on 27/10/2023 to be on 27/10. Sounds like you're wanting to say that's actually 26/10?
Ultimately consistency across the app is the most important thing, hence wondering if there's a precedent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The thought is that it's "end of day" processing--at midnight, it handles events for the previous day.
So since we're doing this at midnight, we want our event to happen at 23:59 to log it to the day that it was assigned to.
This PR is stale because it has been open 45 days with no activity. |
I'm quite invested in this FWIW, just time poor. The meal planner is all but my most used feature and improvements are hugely welcome. |
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #2256
Fixed #2446
Special notes for your reviewer:
Same as PR #2399, just cherry-picked around the changes for the scrolling UI
Testing
For frontend changes, tested manually and confirmed data displays appropriately now.
Ratings
Visually verify stars are present.
Quantities
Validate that the recipe indicates a quantity when it isn't 1.
Add Recipes to the Meal Plan in all possible workflows and verify that specified quantities populate:
Verify that the Edit page properly propagates quantities when modified
For backend changes, modified existing unit test and did additional validation via API calls.
Release Notes