Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use Scraped URL instead of Open Graph URL when importing a recipe via URL #2822

Merged
merged 2 commits into from
Dec 11, 2023
Merged

fix: Use Scraped URL instead of Open Graph URL when importing a recipe via URL #2822

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
275bb96
use scraper URL instead of og tag
michael-genson Dec 11, 2023
e5f278f
Merge branch 'mealie-next' into fix/add-url-to-opengraph-scraper
boc-the-git Dec 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 1 addition & 5 deletions mealie/services/scraper/scraper_strategies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,10 +208,6 @@ async def parse(self):


class RecipeScraperOpenGraph(ABCScraperStrategy):
"""
Abstract class for all recipe parsers.
"""

async def get_html(self, url: str) -> str:
return await safe_scrape_html(url)

Expand Down Expand Up @@ -241,7 +237,7 @@ def og_fields(properties: list[tuple[str, str]], field_name: str) -> list[str]:
"recipeIngredient": ["Could not detect ingredients"],
"recipeInstructions": [{"text": "Could not detect instructions"}],
"slug": slugify(og_field(properties, "og:title")),
"orgURL": og_field(properties, "og:url"),
"orgURL": self.url,
"categories": [],
"tags": og_fields(properties, "og:article:tag"),
"dateAdded": None,
Expand Down