fix: re-enable change user and fix SIGTERM #2882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-genson
previously approved these changes
Dec 28, 2023
hay-kot
force-pushed
the
fix/revert-disable-change-user
branch
from
f9426ef
to
ae95820
Compare
hay-kot
changed the title
hay-kot
commented
Jan 11, 2024
| @@ -138,4 +138,4 @@ EXPOSE ${APP_PORT} | |||
| COPY ./docker/entry.sh $MEALIE_HOME/run.sh | |||
|
|
|||
| RUN chmod +x $MEALIE_HOME/run.sh | |||
| ENTRYPOINT $MEALIE_HOME/run.sh | |||
| ENTRYPOINT ["/app/run.sh"] | |||
There was a problem hiding this comment.
This had to be switched to the JSON type format because of the way docker handles the starting of the container scripts which also doesn't allow us to use env variables in the string, so that's neat!
michael-genson
approved these changes
Jan 11, 2024
|
LGTM. I'll leave it for you to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
Which issue(s) this PR fixes:
(REQUIRED)
Closes #2845
Closes #2723
Closes #2411 (probably)
Special notes for your reviewer:
(fill-in or delete this section)
Testing
(fill-in or delete this section)