Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use GitHub actions for Stale detection #3001

Merged

Conversation

boc-the-git
Copy link
Collaborator

@boc-the-git boc-the-git commented Jan 17, 2024

What type of PR is this?

  • cleanup

What this PR does / why we need it:

We haven't had stalebot working for a while. This implementation gets rid of the old stale config, and introduces the official GitHub Action for stale issues/PRs: https://github.com/marketplace/actions/close-stale-issues

Which issue(s) this PR fixes:

None.

Special notes for your reviewer:

You'll note debug mode is turned on - this means that it should take no action against anything until we remove that flag. Relevant doco

I'll monitor what I can see in the Actions output as time allows, and raise a new PR in the next week or so to remove the flag, including any tweaks that seem worthwhile.

Also TBC whether there'd be permissions issues, but I think we fix forward with that once we see how it wants to act.

Testing

Very little, per the special notes, the plan would be to implement this effectively dormant, and then tweak config as needed based on what we see "in production".

@Kuchenpirat
Copy link
Collaborator

Kuchenpirat commented Jan 17, 2024

only thing im not sure on here is whether 30 (+5) days for issues are enough to close them automatically.
Tho at this point it should have an label that would keep it open, so im fine with the current implementation 👍

@michael-genson michael-genson merged commit f60c60b into mealie-recipes:mealie-next Jan 17, 2024
9 checks passed
@boc-the-git
Copy link
Collaborator Author

boc-the-git commented Jan 17, 2024

Thanks for the comments guys. Definitely happy to review the 30+5, I'm not wedded to any particular value. Main focus with this initial PR was to get it implemented and see how it functions in dry run mode.

@boc-the-git boc-the-git deleted the add-stale-actions branch January 17, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants