fix: password reset link not shown in admin pages #3142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kuchenpirat
changed the title
boc-the-git
approved these changes
Feb 10, 2024
There was a problem hiding this comment.
LGTM.
My understanding @Kuchenpirat is that despite the button wording "cancel", all that is happening is the URL is being hidden from the screen?
I'll allow you to merge after seeing this message 👍
|
Not exactly. It overwrites the reset link with an empty string. This is the same implementation we use for the invite link generation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Shows the password reset link in the GUI at the page
/admin/users/_id. This is necessairy because if the users connects via http copyToClipboard is not availlable. Furthermore it makes it a bit clearer that a link has been generated instead of just adding a little copy button.Screenshots:
Which issue(s) this PR fixes:
Fixes #3141
Special notes for your reviewer:
None
Testing
Manual testing