Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Display nutritional information with values only. #3169

Conversation

Kuchenpirat
Copy link
Collaborator

What type of PR is this?

  • cleanup
  • feature

What this PR does / why we need it:

As described in #3168. Nutritional information also gets shown if no value is asigned
This PR adds a new list that gets used in the view mode that only contains the items that actually have a value. If the user goes into edit mode, all the values are presented.

Which issue(s) this PR fixes:

fixes #3168

Testing

Manual

Screenshots:

Before After
image image

Copy link

@BastianLo BastianLo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I manually tested this change and can approve, that this change is working as expected. Thank you!

Copy link
Collaborator

@michael-genson michael-genson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@michael-genson michael-genson merged commit dc01ff3 into mealie-recipes:mealie-next Feb 13, 2024
9 checks passed
@Kuchenpirat Kuchenpirat deleted the feat--filter-nutritions-with-value branch February 13, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Nutritional info displays empty values
3 participants