fix: Make Mealie Alpha Migrations More Fault Tolerant #3170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-genson
commented
Feb 13, 2024
| @@ -109,6 +111,7 @@ def _save_all_entries(self) -> None: | |||
| if not is_success and not is_failure: | |||
| self.report.status = ReportSummaryStatus.partial | |||
|
|
|||
| self.report.entries = new_entries | |||
There was a problem hiding this comment.
I don't know why this used to work. Since we're saving the report again without updating the report's entry list, it should delete all the report entries that we just created. It's doing that now, but I don't know why it wasn't doing that before
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
This adds some additional
try exceptlogic when migrating from Mealie alpha, so bad recipes don't cause the entire migration to fail. It also restores some broken report functionality (probably broken from the Pydantic upgrade, but who knows) and updates the migration tests to catch if it breaks again.Which issue(s) this PR fixes:
(REQUIRED)
Fixes #3073
Testing
(fill-in or delete this section)
Added a test for bad data handling, and also updated the existing tests to verify the report entries are actually being generated