feat: Switch docker builds to Depot.dev #3172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, awesome work! I'll wait for hay-kot though, he understands the pipeline a lot more than I do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Moves our Docker builds away from the default GitHub Actions runners to using Depot.dev
My limited analysis of why our builds were so slow was that the ARM64 build was the key factor. Doing some research I came across the fact that the ARM builds on GHA are performed via emulation on an AMD64 system.
Switching to Depot.dev, we will get to perform native builds. My testing, which I've shared snippets of on Discord show that builds have reduced to ~3 minutes (without caching!!) compared to ~95 minutes (with caching) we have via GHA. Subsequent cached builds look like they'll be even quicker, but I haven't tested/tweaked that in any meaningful way.
Which issue(s) this PR fixes:
None. But it makes fixing them a hell of a lot quicker!!
Special notes for your reviewer:
Please do not merge the PR, when you approve it! I want to hit the merge button myself when I know I have the time to deal with anything if something were to go wrong. Obviously I'm not expecting that, but I'm just mindful maybe there's a permissions issue or something on the main repo that I've not been able to replicate.
Testing
I've done a lot on my forked repo. Tests included comparing to the best of my ability that the containers built via GHA and Depot were equivalent. Speeds were insanely faster, almost unbelievably so.