Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Shopping List Editor Improvements #3178

Conversation

michael-genson
Copy link
Collaborator

What type of PR is this?

(REQUIRED)

  • feature

What this PR does / why we need it:

(REQUIRED)

This adds a few QoL improvements to the shopping list, some of which are discussed in #3118 (warning: opinions contained within):

  • When creating a new item, the quantity defaults to zero instead of one. Generally, when shopping, you're not specifying the specific quantity (e.g. "Buy Salt" or "Buy Garlic"), and a "zero" quantity effectively just hides the quantity. If you want specific quantities, it's almost always related to a recipe, and adding a recipe to a shopping list already handles the quantity for you anyway. Or, if you actually want to input the quantity on an ad hoc item, it's no more likely to be a quantity of "1" than any other value
  • When selecting a food, the label of the item is automatically updated (if you want the label to be different, you can change it after choosing the food).
  • After you create an item, if you toggled "is food", the next item you create will also have "is food" toggled

See below for a demo of these features; Note in the demo: "salt" and "apple" have foods assigned, but no other foods do.
2024-02-15_15h03_58

Which issue(s) this PR fixes:

(REQUIRED)

Fixes #2910

Testing

(fill-in or delete this section)

Manually, see above

@michael-genson michael-genson enabled auto-merge (squash) February 18, 2024 16:21
Copy link
Collaborator

@boc-the-git boc-the-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michael-genson michael-genson merged commit ea7005e into mealie-recipes:mealie-next Feb 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Shopping list - label for food only appears after saving the entry
2 participants