Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make Meal Planner Notes Not Clickable #3274

Conversation

michael-genson
Copy link
Collaborator

What type of PR is this?

(REQUIRED)

  • bug

What this PR does / why we need it:

(REQUIRED)

Removes most recipes features from the recipe card when anything other than a recipe is passed (i.e. meal plan note cards):

image

Which issue(s) this PR fixes:

(REQUIRED)

Fixes #2350

Special notes for your reviewer:

(fill-in or delete this section)

While we don't use the regular recipes cards this way, I applied the same changes to that component, in case we do something similar in the future. It also keeps the component API consistent.

Testing

(fill-in or delete this section)

Manually

@hay-kot hay-kot merged commit 130813f into mealie-recipes:mealie-next Mar 9, 2024
9 checks passed
@michael-genson michael-genson deleted the fix/meal-planner-notes-clickable branch March 9, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v1.0.0b] - Meal Plan note variants are clickable and send users to a non-existing page
2 participants