feat: Timeline Filters #3284
Merged
feat: Timeline Filters #3284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kuchenpirat
reviewed
Mar 11, 2024
There was a problem hiding this comment.
This looks pretty good 🚀
One bug i have found that if you deselect the filter Checkboxes quite quickly it cannot follow. (Image below)
The checkboxes show everything deselected but the badge shows only one filter, and that is also how the timelime behaves as events are still displayed. The severity of this might increase when the user uses a slower system/connection, or has a lot of timeline events.
Co-authored-by: Kuchenpirat <24235032+Kuchenpirat@users.noreply.github.com>
Co-authored-by: Kuchenpirat <24235032+Kuchenpirat@users.noreply.github.com>
|
Pretty sure the bug you saw with the checkbox being out of sync is fixed. Let me know if you're able to reproduce. I noticed it only got out of sync when clicking on the checkbox (vs clicking on the label) so try clicking on both, if you can |
Kuchenpirat
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
Adds filters to the recipe timeline:
Filters are stored in user preferences so they're persisted. When one or more filters are selected, there's a badge on the button:
There are also a few miscellaneous improvements:
Which issue(s) this PR fixes:
(REQUIRED)
Closes #3250
Testing
Manually poking around