OIDC Docs Updates #3323
Merged
OIDC Docs Updates #3323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boc-the-git
reviewed
Mar 20, 2024
| @@ -41,7 +41,8 @@ markdown_extensions: | |||
| custom_checkbox: true | |||
| - admonition | |||
| - attr_list | |||
| - pymdownx.tabbed | |||
| - pymdownx.tabbed: | |||
| alternate_style: true | |||
There was a problem hiding this comment.
@cmintey can you provide some information on what this change is intending to address please?
Other than that, this PR looks fine to me 👍
There was a problem hiding this comment.
When I first started the PR I wanted to have tabs in the document to display configuration for different versions and I found that the tabs were broken and we needed to add this configuration.
I've since removed the docs that used the tabs, but there are other usages of them that were also broken, so that should be fixed with this
boc-the-git
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Cleans up and clarifies some wording around OIDC enviornment variables.
Removes the examples from the docs and adds a link to examples in the GitHub discussions to make it easier for other users to add/update/comment specific configurations