fix: Missing Translations #3494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boc-the-git
merged commit b38c19c
into
mealie-recipes:mealie-next
9 of 10 checks passed
|
As a translator, it seems very hard to translate "1 Cup Flour". My question is: is it an example of a recipe note that we can localize using our country most favorite units? |
|
Yes, I probably should've named it something more general. It's basically the default ingredient on all new recipes, so any "basic ingredient" works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
This PR adds missing translation files, and inserts new translation logic for new recipes. The missing
dateTimeFormatJSON files led to date-related strings not being translated (see #3490).Which issue(s) this PR fixes:
(REQUIRED)
Fixes #3490
Special notes for your reviewer:
(fill-in or delete this section)
The codegen for locales seems to be broken, so I had to add the file defs manually. Maybe it works when you have the Crowdin API key, but it seems broken even without it. Either way, we were missing files, which I think had to be added manually anyway.
Additionally, the new recipe text might get replaced at some point (see: #2012), but at least for now we can translate what we have.
Testing
(fill-in or delete this section)
Confirmed on #3490 that it looks right for one of the missing languages (Slovenian), and confirmed the new recipe text works as expected.