OIDC - Specifically check for 401 status before resetting #3500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Nightly image does not allow signing into Mealie on mobile (iPhone) devices, but web (multiple browsers) works just fine
Which issue(s) this PR fixes:
Fixes #3499
Special notes for your reviewer:
Pulled down the nightly image this morning and found I couldn't log in on my mobile device (iPhone), but it was fine on web (multiple browsers). I assumed it was due to the previous fix for the infinite redirect. Through some debugging, I tracked the issue down to this one specific line where we reset the auth if there is an error. I honestly think there was some sort of race condition, but adding a check to look if the response was specifically a 401 before resetting seems to have fixed the problem.
Testing
Manual testing on mobile device and web