fix: Make Nextcloud Migrations Fault Tolerant #3544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0lycarpio
reviewed
May 3, 2024
boc-the-git
approved these changes
May 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
Adds a try/except block in Nextcloud migrations to skip over individual failures. This also fixes nutrition data parsing as detailed in #3543 by ignoring empty nutrition values and coercing number values into strings.
Which issue(s) this PR fixes:
(REQUIRED)
Fixes #3543
Testing
(fill-in or delete this section)
Manually tested the .zip file provided in #3543 before (to confirm failure) and after (to confirm success).