feat: Default To Fractions When Unit Is Empty #3587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-genson
force-pushed
the
feat/default-to-fractions-when-unit-is-null
branch
from
741c221
to
d97c973
Compare
hay-kot
approved these changes
May 12, 2024
boc-the-git
pushed a commit
to boc-the-git/mealie
that referenced
this pull request
May 23, 2024
Co-authored-by: Hayden <64056131+hay-kot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
Units decide whether a quantity should use a fraction or a decimal. If there is no unit, we default to decimal. I can't think of a single situation where we would prefer this. Here are some examples where we prefer a fraction:
This PR makes fractions the default, unless specified by the unit.
Which issue(s) this PR fixes:
(REQUIRED)
Closes #3582
Testing
(fill-in or delete this section)
I added a backend and frontend test to check for this scenario, and manually verified in the app.