feat: Set default number of days on meal planner #3650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
.. I'm not opposed to UI improvements.. I just wasn't seeing a lot of scope for it with what Vuetify had available to me. |
|
Should it maybe go into the settings menu instead? Otherwise LGTM, though I'd like to get eyes from someone else since I don't use the meal planner |
On Discord the consensus was to put it here (in development channel). I agree in theory settings would make sense but the current settings is actually very specific to "meal plan rules" and not really a general settings page. |
|
Ah okay, I vaguely remember that. Thanks! |
michael-genson
approved these changes
May 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Allows a user to set their default number of days for the meal planner - which previously was always a week.
The implementation was workshopped on Discord.
Importantly I made the default something used on page load, and independent of what someone might choose in the calendar on that instance of the page. (see 2nd gif)
Which issue(s) this PR fixes:
None.
Testing
Manual.