feat: Handle Safari-mangled backup ZIPs and improve backup UI #3674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boc-the-git
reviewed
Jun 1, 2024
boc-the-git
approved these changes
Jun 1, 2024
There was a problem hiding this comment.
This LGTM, though I am a bit curious re my other comment.
Assuming there's no cause for concern there, happy for you to merge @michael-genson 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
We've had several instances like this where Safari mangles the ZIP file structure, breaking our backups. This PR adds some logic to detect when this happens and work around it.
The UI is also very unhelpful when backups fail, so this PR fixes some state issues and flashes an alert to check server logs when a backup fails.
Which issue(s) this PR fixes:
(REQUIRED)
No open issues, several closed ones where the solution was just to fix the ZIP structure
Testing
(fill-in or delete this section)
I added a mangled zip file test before implementing the workaround, confirmed it failed, and now it passes