fix: Make fractions in the ingredient list look a tiny bit nicer #3725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the spacing a bit more tight.
|
Would you be able to post some screenshots of before and after? I see a couple in the discussion, but a few more here would be nice. Also, can you show how this affects decimals/whole numbers? (if at all)
You can just mark this as ready (assuming it's ready) |
…o undesired side effects
michael-genson
requested changes
Jun 12, 2024
michael-genson
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make fractions in the ingredient list look a tiny bit nicer by making the spacing a bit more tight.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
The goal of this PR is to make fractions in the ingredient list look a bit nicer. Only one file is changed:
frontend/components/Domain/Recipe/RecipeIngredientListItem.vue: Added a CSS class to the quantity part of the ingredient item, and added some CSS to make the spacing in and around the fraction a bit tighter.Which issue(s) this PR fixes:
(REQUIRED)
Fixes #3724
Screenshots
Before
After