Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added images to PWA shortcuts #3744

Merged

Conversation

Choromanski
Copy link
Contributor

What type of PR is this?

  • bug
  • feature

What this PR does / why we need it:

It adds icons to the PWA shortcuts, currently on android the shortcuts have a white square next to them. This adds icons that match the menu bar.

Before

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

I kinda guessed where to put the SVGs and what to name them as they need to be publicly addressable. I'm open to changing there location/names.

Testing

Built the docker container and was able to get the images to work, no other functionality has changed.

After

@Choromanski Choromanski changed the title Added images to PWA shortcuts feat: Added images to PWA shortcuts Jun 17, 2024
@michael-genson
Copy link
Collaborator

michael-genson commented Jun 17, 2024

LGTM, though I'm a little confused why this works; @boc-the-git any idea why this seems to work and it didn't work on your initial PR? Maybe because they're svgs?

Initial PWA shortcuts PR: #3255

@Choromanski
Copy link
Contributor Author

It looks like they only defined the app icons and didn't define any shortcut icons.

w3c documentation example

@michael-genson
Copy link
Collaborator

In boc's initial commit he did, he just removed them since they didn't work: 00f32ae

Reverted here: 1a158d1

@Choromanski
Copy link
Contributor Author

It's super finicky when I tried putting the "type" field in it didn't work.

@boc-the-git
Copy link
Collaborator

LGTM, though I'm a little confused why this works; @boc-the-git any idea why this seems to work and it didn't work on your initial PR? Maybe because they're svgs?

Initial PWA shortcuts PR: #3255

No idea. Maybe I tried png only and it didn't work. Maybe something else.

This PR makes me extremely happy! Well done @Choromanski

@michael-genson
Copy link
Collaborator

michael-genson commented Jun 17, 2024

??? That's so bizarre. Okay good enough for me. Thanks! The icons have been bugging me forever

@michael-genson michael-genson merged commit 598b0f3 into mealie-recipes:mealie-next Jun 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants