feat: fr-BE addition #4000
Closed
feat: fr-BE addition #4000
+0
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-genson
requested changes
Aug 7, 2024
michael-genson
requested changes
Aug 7, 2024
| @@ -35,6 +35,7 @@ class LocaleData: | |||
| "es-ES": LocaleData(name="Español (Spanish)"), | |||
| "fi-FI": LocaleData(name="Suomi (Finnish)"), | |||
| "fr-FR": LocaleData(name="Français (French)"), | |||
| "fr-BE": LocaleData(name="Français (Belgique)"), | |||
There was a problem hiding this comment.
The convention we're using here is "Localized Name (English Name)". Something like "Belgique Français (Belgian French"). I don't speak French so that translation is probably wrong, but you get the idea.
There was a problem hiding this comment.
I'm gonna go with "Belge (Belgian)" then :)
| @@ -162,6 +162,12 @@ export const LOCALES = [ | |||
| progress: 100, | |||
| dir: "ltr", | |||
| }, | |||
| { | |||
| name: "Français (Belgium)", | |||
There was a problem hiding this comment.
Same here, should match gen_ts_locales.py
TheSuperBeaver
force-pushed
the
mealie-next
branch
from
e087fce
to
d53f81c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
There is a small difference between french from France, and french from Belgium
In France :
breakfast : "Petit-déjeuner",
lunch: "Déjeuner",
dinner: "Dîner"
In Belgium :
breakfast: "Petit-déjeuner",
lunch: "Dîner",
dinner: "Souper"
Which issue(s) this PR fixes:
Special notes for your reviewer:
The lang should be created in crowdin also
Testing
Switched to language, and verified that dinner is now "Souper"