This repository has been archived by the owner on May 26, 2018. It is now read-only.
Apply topify on fullscreen change to keep it on the top #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meandavejustice
force-pushed
the
979-foreground-exit-fullscreen
branch
from
dd3cb79
to
544b845
Compare
jaredhirsch
approved these changes
Aug 29, 2017
There was a problem hiding this comment.
Code LGTM 👍
Flows I tested, touchbar 13" 2017 MBP on 10.12.6:
- fullscreen a firefox window with minvid open. topify correctly puts minvid on top.
- fullscreen a firefox window with minvid open, then exit fullscreen mode. topify again maintains the topmost window status.
- fullscreen another app window with minvid open: minvid window is not shown but audio continues.
- open minvid, then hit the screen saver. minvid window is correctly not shown, and audio continues. Audio continues in regular firefox as well, so this is IMO expected behavior.
I think for (3) to work, we'll have to go platform-specific and figure out how to detect when any app goes fullscreen on mac. The same code would detect when the user swipes between 'Spaces' (desktops), as fullscreened mac apps extend the Spaces analogy. I'll add some comments to the original bug and land this for now.
meandavejustice
pushed a commit
that referenced
this pull request
Aug 29, 2017
This reverts commit 50fc883.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@6a68 This still needs to be tested on mac to ensure it actually works :p