Skip to content

Commit

Permalink
Merge pull request #507 from nstanard/destroy-event-doc-update
Browse files Browse the repository at this point in the history 
Updated destroy event documentation
  • Loading branch information
@nstanard
nstanard committed Nov 28, 2016
2 parents 771c4b5 + d2cbc9a commit 6b19ae5
Show file tree
Hide file tree
Showing 3 changed files with 50 additions and 34 deletions.
14 changes: 9 additions & 5 deletions README.md
View file
Expand Up @@ -9,7 +9,7 @@ Please visit: [http://meandmax.github.io/lory/](http://meandmax.github.io/lory/
[![license](http://img.shields.io/badge/license-MIT-blue.svg?style=flat)](https://raw.githubusercontent.com/meandmax/lory/master/LICENSE)
[![npm](http://img.shields.io/npm/v/lory.js.svg?style=flat)](https://www.npmjs.com/package/lory.js)
[![CDNJS](https://img.shields.io/cdnjs/v/lory.js.svg)](https://cdnjs.com/libraries/lory.js/)
[![CDNJS](https://img.shields.io/cdnjs/v/lory.js.svg)](https://cdnjs.com/libraries/lory.js/)

[![build](http://img.shields.io/travis/meandmax/lory/master.svg?style=flat)](https://travis-ci.org/meandmax/lory)
[![code climate](http://img.shields.io/codeclimate/github/meandmax/lory.svg?style=flat)](https://codeclimate.com/github/meandmax/lory)
Expand Down Expand Up @@ -325,6 +325,14 @@ li {
<td>after.lory.slide</td>
<td>fires after slide change | <strong>arguments:</strong> currentSlide</td>
</tr>
<tr>
<td>before.lory.destroy</td>
<td>fires before the slider instance gets destroyed</td>
</tr>
<tr>
<td>after.lory.destroy</td>
<td>fires after the slider instance gets destroyed</td>
</tr>
<tr>
<td>on.lory.resize</td>
<td>fires on every resize event</td>
Expand All @@ -341,10 +349,6 @@ li {
<td>on.lory.touchend</td>
<td>fires on every slider touchend event</td>
</tr>
<tr>
<td>on.lory.destroy</td>
<td>fires when the slider instance gets destroyed</td>
</tr>
</table>

## Getting Help
Expand Down
34 changes: 20 additions & 14 deletions index.html
View file
Expand Up @@ -91,7 +91,7 @@ <h2>Prerequisited CSS styles</h2>
*/
width: 880px;
}

.prev, .next {
position: absolute;
top: 50%;
Expand Down Expand Up @@ -180,7 +180,7 @@ <h2>Single element - dot navigation</h2>
var dot_count = simple_dots.querySelectorAll('.js_slide').length;
var dot_container = simple_dots.querySelector('.js_dots');
var dot_list_item = document.createElement('li');

function handleDotEvent(e) {
if (e.type === 'before.lory.init') {
for (var i = 0, len = dot_count; i < len; i++) {
Expand Down Expand Up @@ -210,9 +210,9 @@ <h2>Single element - dot navigation</h2>
}
}
simple_dots.addEventListener('before.lory.init', handleDotEvent);
simple_dots.addEventListener('after.lory.init', handleDotEvent);
simple_dots.addEventListener('after.lory.slide', handleDotEvent);
simple_dots.addEventListener('on.lory.resize', handleDotEvent);
simple_dots.addEventListener('after.lory.init', handleDotEvent);
simple_dots.addEventListener('after.lory.slide', handleDotEvent);
simple_dots.addEventListener('on.lory.resize', handleDotEvent);

var dot_navigation_slider = lory(simple_dots, {
infinite: 1,
Expand Down Expand Up @@ -489,12 +489,13 @@ <h2>Showing events</h2>
events.addEventListener('after.lory.init', handleEvent);
events.addEventListener('before.lory.slide', handleEvent);
events.addEventListener('after.lory.slide', handleEvent);
events.addEventListener('before.lory.destroy', handleEvent);
events.addEventListener('after.lory.destroy', handleEvent);

events.addEventListener('on.lory.resize', handleEvent);
events.addEventListener('on.lory.touchend', handleEvent);
events.addEventListener('on.lory.touchmove', handleEvent);
events.addEventListener('on.lory.touchstart', handleEvent);
events.addEventListener('on.lory.destroy', handleEvent);

lory(events, {
infinite: 1
Expand Down Expand Up @@ -746,6 +747,14 @@ <h2>Events</h2>
<td><strong>arguments:</strong> currentSlide</td>
<td>fires after slide change</td>
</tr>
<tr>
<th>before.lory.destroy</th>
<td>fires before the slider instance gets destroyed</td>
</tr>
<tr>
<th>after.lory.destroy</th>
<td>fires after the slider instance gets destroyed</td>
</tr>
<tr>
<th>on.lory.resize</th>
<td>fires on every resize event</td>
Expand All @@ -762,10 +771,6 @@ <h2>Events</h2>
<th>on.lory.touchend</th>
<td>fires on every slider touchend event</td>
</tr>
<tr>
<th>on.lory.destroy</th>
<td>fires when the slider instance gets destroyed</td>
</tr>
</table>
</section>

Expand Down Expand Up @@ -829,9 +834,9 @@ <h2>Events</h2>
}
}
simple_dots.addEventListener('before.lory.init', handleDotEvent);
simple_dots.addEventListener('after.lory.init', handleDotEvent);
simple_dots.addEventListener('after.lory.slide', handleDotEvent);
simple_dots.addEventListener('on.lory.resize', handleDotEvent);
simple_dots.addEventListener('after.lory.init', handleDotEvent);
simple_dots.addEventListener('after.lory.slide', handleDotEvent);
simple_dots.addEventListener('on.lory.resize', handleDotEvent);

var dot_navigation_slider = lory(simple_dots, {
infinite: 1,
Expand Down Expand Up @@ -885,12 +890,13 @@ <h2>Events</h2>
events.addEventListener('after.lory.init', handleEvent);
events.addEventListener('before.lory.slide', handleEvent);
events.addEventListener('after.lory.slide', handleEvent);
events.addEventListener('before.lory.destroy', handleEvent);
events.addEventListener('after.lory.destroy', handleEvent);

events.addEventListener('on.lory.resize', handleEvent);
events.addEventListener('on.lory.touchend', handleEvent);
events.addEventListener('on.lory.touchmove', handleEvent);
events.addEventListener('on.lory.touchstart', handleEvent);
events.addEventListener('on.lory.destroy', handleEvent);

lory(events, {
infinite: 1
Expand Down
36 changes: 21 additions & 15 deletions src/index.html
View file
Expand Up @@ -91,7 +91,7 @@ <h2>Prerequisited CSS styles</h2>
*/
width: 880px;
}

.prev, .next {
position: absolute;
top: 50%;
Expand Down Expand Up @@ -248,7 +248,7 @@ <h2>Single element - dot navigation</h2>
var dot_count = simple_dots.querySelectorAll('.js_slide').length;
var dot_container = simple_dots.querySelector('.js_dots');
var dot_list_item = document.createElement('li');

function handleDotEvent(e) {
if (e.type === 'before.lory.init') {
for (var i = 0, len = dot_count; i < len; i++) {
Expand Down Expand Up @@ -278,9 +278,9 @@ <h2>Single element - dot navigation</h2>
}
}
simple_dots.addEventListener('before.lory.init', handleDotEvent);
simple_dots.addEventListener('after.lory.init', handleDotEvent);
simple_dots.addEventListener('after.lory.slide', handleDotEvent);
simple_dots.addEventListener('on.lory.resize', handleDotEvent);
simple_dots.addEventListener('after.lory.init', handleDotEvent);
simple_dots.addEventListener('after.lory.slide', handleDotEvent);
simple_dots.addEventListener('on.lory.resize', handleDotEvent);

var dot_navigation_slider = lory(simple_dots, {
infinite: 1,
Expand Down Expand Up @@ -489,12 +489,13 @@ <h2>Showing events</h2>
events.addEventListener('after.lory.init', handleEvent);
events.addEventListener('before.lory.slide', handleEvent);
events.addEventListener('after.lory.slide', handleEvent);
events.addEventListener('before.lory.destroy', handleEvent);
events.addEventListener('after.lory.destroy', handleEvent);

events.addEventListener('on.lory.resize', handleEvent);
events.addEventListener('on.lory.touchend', handleEvent);
events.addEventListener('on.lory.touchmove', handleEvent);
events.addEventListener('on.lory.touchstart', handleEvent);
events.addEventListener('on.lory.destroy', handleEvent);

lory(events, {
infinite: 1
Expand Down Expand Up @@ -746,6 +747,14 @@ <h2>Events</h2>
<td><strong>arguments:</strong> currentSlide</td>
<td>fires after slide change</td>
</tr>
<tr>
<th>before.lory.destroy</th>
<td>fires before the slider instance gets destroyed</td>
</tr>
<tr>
<th>after.lory.destroy</th>
<td>fires after the slider instance gets destroyed</td>
</tr>
<tr>
<th>on.lory.resize</th>
<td>fires on every resize event</td>
Expand All @@ -762,10 +771,6 @@ <h2>Events</h2>
<th>on.lory.touchend</th>
<td>fires on every slider touchend event</td>
</tr>
<tr>
<th>on.lory.destroy</th>
<td>fires when the slider instance gets destroyed</td>
</tr>
</table>
</section>

Expand Down Expand Up @@ -799,7 +804,7 @@ <h2>Events</h2>
infinite: 1,
enableMouseEvents: true
});

function handleDotEvent(e) {
if (e.type === 'before.lory.init') {
for (var i = 0, len = dot_count; i < len; i++) {
Expand Down Expand Up @@ -829,9 +834,9 @@ <h2>Events</h2>
}
}
simple_dots.addEventListener('before.lory.init', handleDotEvent);
simple_dots.addEventListener('after.lory.init', handleDotEvent);
simple_dots.addEventListener('after.lory.slide', handleDotEvent);
simple_dots.addEventListener('on.lory.resize', handleDotEvent);
simple_dots.addEventListener('after.lory.init', handleDotEvent);
simple_dots.addEventListener('after.lory.slide', handleDotEvent);
simple_dots.addEventListener('on.lory.resize', handleDotEvent);

var dot_navigation_slider = lory(simple_dots, {
infinite: 1,
Expand Down Expand Up @@ -885,12 +890,13 @@ <h2>Events</h2>
events.addEventListener('after.lory.init', handleEvent);
events.addEventListener('before.lory.slide', handleEvent);
events.addEventListener('after.lory.slide', handleEvent);
events.addEventListener('before.lory.destroy', handleEvent);
events.addEventListener('after.lory.destroy', handleEvent);

events.addEventListener('on.lory.resize', handleEvent);
events.addEventListener('on.lory.touchend', handleEvent);
events.addEventListener('on.lory.touchmove', handleEvent);
events.addEventListener('on.lory.touchstart', handleEvent);
events.addEventListener('on.lory.destroy', handleEvent);

lory(events, {
infinite: 1
Expand Down

0 comments on commit 6b19ae5

Please sign in to comment.