Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submenus do not close [IE8/9] #16

Closed
GoSpursGoNL opened this issue Aug 5, 2013 · 9 comments
Closed

Submenus do not close [IE8/9] #16

GoSpursGoNL opened this issue Aug 5, 2013 · 9 comments

Comments

@GoSpursGoNL
Copy link

I'm testing SuperFish+Meanmenu and noticed 1 problem in IE8/9: you can open sub-menu's, but you can't close them anymore. If you click on the minus-sign, the sign changes into a plus-sign, but the submenu does not close.

This also occurs on the MeanMenu demo page in IE8/9:
http://www.meanthemes.com/demo/meanmenu/demo.html

Besides I was wondering why the demo page contains code that does not seem to be used anywhere (not in the CSS, neither in MeanMenu), like
""

@GoSpursGoNL
Copy link
Author

I see the issue has been closed, does that mean the bug will be solved?

@cdwharton
Copy link
Collaborator

How weird, my response didn't get posted.

The "" code is in there as its part of the boilerplate we use. It has no impact on the plugin.

You'll need to activate superfish at the correct breakpoint where meanmenu kicks in e.g.

jQuery('header nav').meanmenu({
    meanScreenWidth: "620",
    meanRevealPosition: "center"
});


jQuery(function () {
        if( jQuery(window).width() > 620) {
            jQuery('header nav ul').superfish({
                autoArrows: false,
                dropShadows: false
            });
        }
    });

@GoSpursGoNL
Copy link
Author

Yeah the menu works perfectly fine in all browsers, however in IE8/9 submenu's don't close after opening them. This also happens when loading your own demo page in IE8/9

@cdwharton
Copy link
Collaborator

Ok, I'll reopen this and look into it. I thought it was a Superfish specific issue.

@cdwharton cdwharton reopened this Aug 12, 2013
@cdwharton
Copy link
Collaborator

I've just tested in IE10 running compatibility mode for IE8 and IE9 and it works fine.

However, having just double checked on Browser stack I've found and solved the issue. Can you believe a line break in the code breaks the contract of the menu!

Can you test http://www.meanthemes.com/demo/meanmenu/demo.html (you may need to refresh a couple of times or clear your cache) and see if its working for you now?

@GoSpursGoNL
Copy link
Author

Works great now! What do I have to change to make the menu work on my own site?

@cdwharton
Copy link
Collaborator

You can re-download the MeanMenu JS and replace that, its probably the easiest thing to do.

@cdwharton
Copy link
Collaborator

I'm closing this issue down now as it is resolved and you are happy :)

@GoSpursGoNL
Copy link
Author

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants