Integration of wordpress blog #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mailtime-wing
force-pushed
the
master
branch
from
062463a
to
ac9d34d
Compare
chochihim
requested changes
Dec 19, 2019
There was a problem hiding this comment.
Please take a look on all of my comments on specific file/lines. Also, please fix below in general
- Please use .svg instead of .png
- You don't need to always wrap your component in
<>...</> - Is it possible to use your
Buttoncomponent to replace usage of the purple-arrow image? Also please do not use such a generic name for this component. - Please use
<FormattedMessage />for static text. Add corresponding translation tosrc/intlas well. - Sub-components should be put above main component
src/components/BlogPost/index.js
Outdated
| <ReadMore>Read more ...</ReadMore> | ||
| <ViewCountContainer> | ||
| <ViewCountImage src={viewCountIcon} /> | ||
| <ViewCount>320</ViewCount> |
There was a problem hiding this comment.
How can we get this info instead of hardcoded?
There was a problem hiding this comment.
hided view count right now.
Don has created the view counts in wordpress, but cannot query in graphql(do not have that field in allWordpressPost/wordpressPost).
The only way to get the view count is getting from below url with postId
https://blog.measurable.ai/wp-json/pvc/v1/view/ + post id
Any suggestions?
2. change sup component order
chochihim
requested changes
Dec 20, 2019
chochihim
requested changes
Dec 20, 2019
chochihim
requested changes
Dec 24, 2019
chochihim
approved these changes
Dec 27, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review. Thanks!