Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade puck to v0.15.0 #160

Merged
merged 5 commits into from
Jun 19, 2024
Merged

Upgrade puck to v0.15.0 #160

merged 5 commits into from
Jun 19, 2024

Conversation

monospaced
Copy link
Member

No description provided.

Copy link

vercel bot commented Apr 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
measuredco-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2024 3:34pm

@monospaced monospaced changed the title build: upgrade puck to v0.14.2 Upgrade puck to v0.14.2 Apr 19, 2024
@monospaced monospaced changed the title Upgrade puck to v0.14.2 Upgrade puck to v0.14.2 Apr 19, 2024
@monospaced monospaced changed the title Upgrade puck to v0.14.2 Upgrade puck to v0.14.2 Apr 19, 2024
@monospaced monospaced marked this pull request as ready for review April 19, 2024 12:46
Copy link
Member

@chrisvxd chrisvxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need a body margin reset now

image

@monospaced
Copy link
Member Author

@chrisvxd

I think you need a body margin reset now

There is one on the site, so that is a bit confusing. I think maybe it's the outer body in your screenshot that's coming from the site (as can also see lang="en-gb" style={{ scrollBehavior: "smooth" }} on the outer html). Is the body inside the frame not under puck control?

https://github.com/measuredco/measuredco-site/blob/main/app/layout.tsx#L54

@chrisvxd
Copy link
Member

The site implementation is just using inline styles. Puck won't copy over inline styles on the body. I would add a body { margin: 0 } definition to the stylesheet.

@monospaced monospaced changed the title Upgrade puck to v0.14.2 Upgrade puck to v0.15.0 Jun 19, 2024
Copy link
Member

@chrisvxd chrisvxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@monospaced monospaced merged commit fda94f1 into main Jun 19, 2024
2 checks passed
@monospaced monospaced deleted the puck-0.14.2 branch June 19, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants