Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Lucide icons #285

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Migrate to Lucide icons #285

merged 1 commit into from
Dec 18, 2023

Conversation

danielbayley
Copy link
Contributor

@danielbayley danielbayley commented Dec 11, 2023

https://lucide.dev

Actively maintained fork of Feather icons, with a much improved selection of icons! (I am a major contributor).

https://lucide.dev/guide/packages/lucide-react

Lucide is built with ES Modules, so it's completely tree-shakable.

Copy link

vercel bot commented Dec 11, 2023

@danielbayley is attempting to deploy a commit to the Measured Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Dec 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
puck-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2023 1:31pm
puck-docs ✅ Ready (Inspect) Visit Preview Dec 18, 2023 1:31pm

Copy link
Member

@chrisvxd chrisvxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic @danielbayley, thank you.

However, we're close to merging extra-large #265 which may result in conflicts. Would you mind rebasing from main once this has been merged?

@danielbayley
Copy link
Contributor Author

This is fantastic @danielbayley, thank you.

However, we're close to merging extra-large #265 which may result in conflicts. Would you mind rebasing from main once this has been merged?

@chrisvxd Sure, will do.

@chrisvxd
Copy link
Member

@danielbayley #265 has been merged, please rebase when you have a minute

packages/core/components/Puck/index.tsx Outdated Show resolved Hide resolved
Copy link
Member

@chrisvxd chrisvxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @danielbayley. Unfortunately still getting an error regarding an import of react-feather when building the demo app

image

@danielbayley
Copy link
Contributor Author

Thanks @danielbayley. Unfortunately still getting an error regarding an import of react-feather when building the demo app

@chrisvxd Ah that must have slipped through in the process of cleaning up the commits… Fixed.

@chrisvxd
Copy link
Member

Still failing! This time it's lucide

image

Suggest you need to add the dep to the demo app package.json. You should be able to test by running yarn build before pushing.

@danielbayley
Copy link
Contributor Author

Still failing! This time it's lucide

@chrisvxd Ah ok cool, I was going off yarn dev vs yarn build… Fixed and build is succeeding for me locally now.

@chrisvxd
Copy link
Member

Nearly there! Build is working, but linting is failing because of formatting. yarn format should sort you out.

Thanks for the persistence!

@danielbayley
Copy link
Contributor Author

danielbayley commented Dec 18, 2023

Nearly there! Build is working, but linting is failing because of formatting. yarn format should sort you out.

Thanks for the persistence!

@chrisvxd Strange, as yarn lint inside of apps/demo was passing for me locally… It was just a few quotes and semis… All green now!

Copy link
Member

@chrisvxd chrisvxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo, thanks @danielbayley! Appreciate the conventional commit message, too.

@chrisvxd chrisvxd merged commit 2a8c2ff into measuredco:main Dec 18, 2023
4 checks passed
@danielbayley danielbayley deleted the lucide branch December 18, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants