-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Lucide icons #285
Conversation
@danielbayley is attempting to deploy a commit to the Measured Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fantastic @danielbayley, thank you.
However, we're close to merging extra-large #265 which may result in conflicts. Would you mind rebasing from main once this has been merged?
@chrisvxd Sure, will do. |
@danielbayley #265 has been merged, please rebase when you have a minute |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @danielbayley. Unfortunately still getting an error regarding an import of react-feather
when building the demo app
![image](https://private-user-images.githubusercontent.com/985961/291275712-7345db8e-9fce-4677-a51a-9e5fad753260.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjM5MTk2MjcsIm5iZiI6MTcyMzkxOTMyNywicGF0aCI6Ii85ODU5NjEvMjkxMjc1NzEyLTczNDVkYjhlLTlmY2UtNDY3Ny1hNTFhLTllNWZhZDc1MzI2MC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwODE3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDgxN1QxODI4NDdaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1lNjQ3ODRhMGFjNjU0MjhmNTQzNjQ5MTNlM2MwMDZkMzdhY2Y5MmEwYmFiNWEwM2Q5NGNlYzhjZTI3MWJmMzJhJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.DUFXMFik8ZY4pQdjpcW2xQUAzQokEdUKmI2J5z3x6Nc)
@chrisvxd Ah that must have slipped through in the process of cleaning up the |
@chrisvxd Ah ok cool, I was going off |
Nearly there! Build is working, but linting is failing because of formatting. Thanks for the persistence! |
@chrisvxd Strange, as |
ed96ad5
to
fc296b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woohoo, thanks @danielbayley! Appreciate the conventional commit message, too.
https://lucide.dev
Actively maintained fork of Feather icons, with a much improved selection of icons! (I am a major contributor).
https://lucide.dev/guide/packages/lucide-react