This repository has been archived by the owner on Dec 21, 2023. It is now read-only.
Do not use amalgamated header for developing #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #149 +/- ##
=========================================
- Coverage 88.23% 84.94% -3.3%
=========================================
Files 5 6 +1
Lines 1513 2949 +1436
=========================================
+ Hits 1335 2505 +1170
- Misses 178 444 +266
Continue to review full report at Codecov.
|
|
FTR @robertodauria I also fixed the too many builds by disabling this repo from travis-ci.org, which is the legacy CI from Travis, so we only build at travis-ci.com. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale of the PR: when you develop you edit headers that make libndt.hpp. So, let's build tests and the real binary with headers that make libndt.hpp. Then, let's make sure we are also able to generate a libndt.hpp header that compiles, so we don't break it.