Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEO_SUBOPTIMAL_EXPRESSION_ORDER false-negative #266

Open
boris-petrov opened this issue Mar 11, 2018 · 1 comment
Open

SEO_SUBOPTIMAL_EXPRESSION_ORDER false-negative #266

boris-petrov opened this issue Mar 11, 2018 · 1 comment
Labels

Comments

@boris-petrov
Copy link

I have something like:

boolean condition = someComplexExpression();

if (someOtherComplexExpression(1, 2) || condition) {
}

But it doesn't trigger the SEO_SUBOPTIMAL_EXPRESSION_ORDER warning. If you can't reproduce it with a simple example, I'l try to work out a working reproduction.

@mebigfatguy
Copy link
Owner

the problem with or's is that the individual branches have different targets which makes it hard to figure out whether the two are part of the same if condition or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants