FII_USE_METHOD_REFERENCE false positive

[Serranya]

The following code triggres an FII_USE_METHOD_REFERENCE warning

int[] updateCount = ...
Arrays.stream(updateCount).mapToObj(i -> i == 1 ? Boolean.TRUE : Boolean.FALSE).allMatch(b -> b);

I have rewritten the code to the more concise

int[] updateCount = ...
Arrays.stream(updateCount).allMatch(i -> i == 1);

which works. But the warning still seems like a false positive.

[ThrawnCA]

I suspect it was complaining about the i -> i reference. It probably could have been replaced with something like Boolean.TRUE::equals

[Serranya]

Ahh I see. If this is intentional im fine with closing the bug.

[mebigfatguy]

Seems like the problem is the compiler is generating two lambda methods for this one mapToObject invocation. The first

private static java.lang.Boolean lambda$20(int);
descriptor: (I)Ljava/lang/Boolean;
flags: ACC_PRIVATE, ACC_STATIC, ACC_SYNTHETIC
Code:
stack=2, locals=1, args_size=1
0: iload_0
1: iconst_1
2: if_icmpne 11
5: getstatic #322 // Field java/lang/Boolean.TRUE:Ljava/lang/Boolean;
8: goto 14
11: getstatic #328 // Field java/lang/Boolean.FALSE:Ljava/lang/Boolean;
14: areturn

and the second

private static boolean lambda$21(java.lang.Boolean);
descriptor: (Ljava/lang/Boolean;)Z
flags: ACC_PRIVATE, ACC_STATIC, ACC_SYNTHETIC
Code:
stack=1, locals=1, args_size=1
0: aload_0
1: invokevirtual #335 // Method java/lang/Boolean.booleanValue:()Z
4: ireturn

The second lambda is clearly the same as Boolean::valueOf and that is what is being reported. However you didn't write two lambdas the compiler did. Have it figure out how to address this.

[mebigfatguy]

thanks for the report, should be fixed.