Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript Error on mouse leave: "getExerciseResult is not a function" #45

Closed
BiLachner opened this issue Apr 17, 2022 · 5 comments · Fixed by #48
Closed

JavaScript Error on mouse leave: "getExerciseResult is not a function" #45

BiLachner opened this issue Apr 17, 2022 · 5 comments · Fixed by #48
Assignees

Comments

@BiLachner
Copy link

2022-04-17_07-42

Hi, here is an error, we get while using a GeoGebra file. You can find ist here: https://www.geogebra.org/m/mpcwwb2q

And I can't finish the test, even if my result was right.

The problem (i.e. the error message) does not only occur with us in Rhineland-Palatinate, but also with a colleague in Switzerland who has his own moodle instance for testing.

Can you see if it is due to my drawing? Or is something missing? Could it be that the plugin is too old?
Since I'm not an administrator, I can't change anything in the short term, but I would pass it on.

Regards, Birgit

@PhMemmel
Copy link
Member

Thanks @BiLachner for reporting this. Could you please provide the settings you made for this question type by, for example, pasting some screenshots of the settings? Could you also please elaborate how exactly moodle is supposed to get/extract/calculate the result from the GeoGebra applet you provided?

I stumbled over this error before, it happens on all current assignments. Still trying to figure out what this function call is supposed to do :-)
But I can confirm that this error in general does not prevent moodle from reading the boolean variables of the geogebra applet to check if the solution is correct or not, so maybe we have two different issues here.

@PhMemmel PhMemmel changed the title Error Message JavaScript Error on mouse leave: "getExerciseResult is not a function" Apr 22, 2022
@PhMemmel
Copy link
Member

Hi @BiLachner,
I sent a PR to solve this issue. It definitely removes the error. I hope that this also solves the problem of the question not being graded correctly. Please let us know if this part of the problem is solved. If not, please open a new issue for that problem and please provide an example ggb file with the exact settings you did.

@PhMemmel PhMemmel self-assigned this Apr 22, 2022
@BiLachner
Copy link
Author

BiLachner commented Apr 22, 2022

As far as I understand the informations with the pull request, your changes haven't been added yet. When it is done, I'll contact our admin to update and have a look.
Thanks!

@PhMemmel
Copy link
Member

PhMemmel commented Apr 22, 2022

Yes, if you don't have a separate test system where you can manually checkout the changes, you would have to wait until this has been reviewed and merged and a new release has been published on moodle.org.

@PhMemmel
Copy link
Member

PhMemmel commented May 4, 2022

@BiLachner A new version just has been released. You can update the plugin in your moodle and see if the bug is fully gone. It would be awesome if you could let me know, if especially the problem with not being able to finish the task could be solved with this fix. Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants