Set portals when replacing data in Persistable #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! :P I approve this PR! |
|
@Portals :) |
|
Nice catch, I have missed hydrating it back. Since the portals have been built, I think it is safe to merge. I don't think a spec is required but if you have one, why not 😄 |
mech
added a commit
that referenced
this pull request
Mar 10, 2015
Set portals when replacing data in Persistable
|
thanks @mech. i haven't actually written any specs. was just puzzling over this late last night and figured it was just an oversight. |
|
i was thinking that https://github.com/mech/filemaker-ruby/blob/master/lib/filemaker/model/builder.rb could be refactored such that it could be used to handle https://github.com/mech/filemaker-ruby/blob/master/lib/filemaker/model/persistable.rb#L94-L108. may have a PR for that in a little while. |
|
That's wonderful @lannon, 👍 for refactoring them to be together so they are easy to reason about. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can add specs for the Persistable module to cover this. But, wanted to see if not setting @Portals here was intentional.