Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows type support for no_wait_after and timeout in locator calls. #33

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

dbrody
Copy link
Contributor

@dbrody dbrody commented Dec 16, 2021

Updates to allow timeout and no_wait_after options to the types for locators.

@coreyti coreyti merged commit adb1d65 into mechanical-orchard:main Feb 9, 2022
@coreyti
Copy link
Member

coreyti commented Feb 9, 2022

I made a small change: options_with_delay -> options_keyboard. There's no solid pattern yet established for naming those types; this somehow felt better.

Incidentally, I was hoping to find some tests in the official implementations that we could port. Sadly, there are none.

@dbrody dbrody deleted the hotfix/locator-params branch February 10, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants