Skip to content
This repository has been archived by the owner on Mar 29, 2023. It is now read-only.

[Work in Progress] Functionality to highlight user list #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

girish3
Copy link

@girish3 girish3 commented Dec 21, 2019

Added the filter to highlight words in User list and included the control element in the setting page for the same.

Note: Localization and finer setting controls is pending.

Issue: #14

Copy link
Owner

@mechatroner mechatroner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. Do I understand correctly that the only thing which remains to be done is to implement uploading of the custom user word list?

@@ -466,9 +466,19 @@ function initialize_extension() {
useColor: true,
color: "blue"
};
user_word_hl_params = {
enabled: true,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understing was that the list should be disabled by default (until user uploads it)

backgroundColor: "rgb(255, 248, 220)",
useColor: true,
color: "green"
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing semicolon!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants