Rename #101
Merged
Rename #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41 and #88
The following renames have been done:
...Pedals...-->...Cranks...(9c7cc38)BicycleBase.pedals-->BicycleBase.cranks(9c7cc38)...PedalsToFeet...-->...Pedals...(e3b4475)BicycleRider.pedal_connection-->BicycleRider.pedals(e3b4475)brim/bicycle/pedals.py-->brim/bicycle/cranks.py(9c7cc38)brim/core/model_base.py-->brim/core/base_classes(99cfa73)brim/bicycle/tyre_models.py-->brim/bicycle/tyres.py(7a94c8d)BicycleRider.seat_connection-->BicycleRider.seat(5e4db79)brim/brim/seat_connections-->brim/brim/seat.py(5e4db79)...HandGrip...-->...HandGrips...(104c4ef)BicycleRider.steer_connection-->BicycleRider.hand_grips(19fdcd5 a3a11b5)brim/brim/steer_connections.py-->brim/brim/hand_grips.py(40217a6 d30f858)HandGripBase.steer-->HandGripBase.front_frame(e25040b 9f71a8e)...PelvisToTorso...-->...Sacrum...(d3ef71a)Rider.pelvis_to_torso-->Rider.sacrum(d3ef71a)I think these are all applied renames. Should note that some test classes have also been renamed, but that does not affect the implementation.