Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unbreak consumers on more Unices #21

Merged
merged 1 commit into from Dec 4, 2018
Merged

Unbreak consumers on more Unices #21

merged 1 commit into from Dec 4, 2018

Conversation

jbeich
Copy link
Contributor

@jbeich jbeich commented Dec 2, 2018

NASM defaults to bin format (e.g. DOS .COM, .SYS). DragonFly, FreeBSD, NetBSD, OpenBSD, Solaris, GNU Hurd and probably more systems use ELF. NASM supports more formats but those are less likely to be supported by Rust and aren't shared on many platforms.

Found via rav1e on FreeBSD x86_64:

$ cargo build
[...]
     Running `/path/to/rav1e/target/debug/build/rav1e-930659fb03421608/build-script-build`
error: failed to run custom build command for `rav1e v0.1.0 (/a/rav1e)`
process didn't exit successfully: `/path/to/rav1e/target/debug/build/rav1e-930659fb03421608/build-script-build` (exit code: 101)
--- stdout
running: "nasm" "" "-g" "-I/path/to/rav1e/target/debug/build/rav1e-bf67f461e7fd7434/out/" "-Isrc/" "/path/to/rav1e/src/x86/ipred.asm" "-o" "/path/to/rav1e/target/debug/build/rav1e-bf67f461e7fd7434/out/src/x86/ipred.o"

--- stderr
/path/to/rav1e/src/x86/ipred.asm:100: error: impossible combination of address sizes
src/ext/x86/x86inc.asm:1424: ... from macro `movdqu' defined here
src/ext/x86/x86inc.asm:1288: ... from macro `RUN_AVX_INSTR' defined here
src/ext/x86/x86inc.asm:1748: ... from macro `vmovdqu' defined here
[...]
thread 'main' panicked at 'nonzero exit status: exit code: 1', /home/foo/.cargo/git/checkouts/nasm-rs-4e8d02e8a0db2eea/7c01c74/src/lib.rs:340:9
note: Run with `RUST_BACKTRACE=1` for a backtrace.

@medek medek merged commit 544a479 into medek:master Dec 4, 2018
@jbeich
Copy link
Contributor Author

jbeich commented Dec 4, 2018

@tdaede, can you also merge this into your fork as used by rav1e?

@tdaede
Copy link
Contributor

tdaede commented Dec 11, 2018

@jbeich I opened a PR for the patch in my fork, once it's merged I'll just point rav1e to this repo.

@jbeich
Copy link
Contributor Author

jbeich commented Dec 22, 2018

@tdaede, #22 got merged >1 week ago. Are you waiting on @medek to push 0.1.4 to crates.io with #21 and #22 or what?

@tdaede
Copy link
Contributor

tdaede commented Dec 22, 2018

Whoops, totally forgot. Opened a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants