feat: update definitions endpoint #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcAntoine-Arnaud
requested changes
Apr 7, 2021
| @@ -2,9 +2,26 @@ defmodule StepFlow.WorkflowDefinitionView do | |||
| use StepFlow, :view | |||
| alias StepFlow.WorkflowDefinitionView | |||
|
|
|||
| def render("index.json", %{workflow_definitions: %{data: workflow_definitions, total: total}}) do | |||
| def render("index.json", %{ | |||
| workflow_definitions: %{data: workflow_definitions, total: total, mode: "full"} | |||
There was a problem hiding this comment.
do not match here, just wrote:
def render("index.json", %{workflow_definitions: %{data: workflow_definitions, total: total, mode: mode}
data: render_many(workflow_definitions, WorkflowDefinitionView, "workflow_definition_#{mode}.json"),
end| end | ||
| end | ||
|
|
||
| defp filter_by_laber_or_identifier(query, search) do |
added 2 commits
April 7, 2021 14:51
fix travis using postgres 9.6 fix test list definitions
mix format match definition view on mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.