New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge from concat -> aleph nodes #152
Conversation
I'm assuming build failures here are related to what vyzo is working on right now? |
pretty sure this was another case of go dependencies getting out of sync with our docker image. I rebuilt it and re-ran... one failed with "MAC invalid" (wtf?) |
yeah I've seen the MAC invalid error a few times in this situation (every time?) |
{hello: 'world'}, | ||
{foo: 'bar'}, | ||
{etc: 'and so on'} | ||
{id: uuid.v4(), hello: 'world'}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious, was there a specific reason for doing this? Are the tests noticeably faster this way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to make sure that data from one test wouldn't "contaminate" the results for a subsequent test, since I'm asserting on e.g. the number of objects merged, and if I unthinkingly reuse the same {foo: "bar"}
object in multiple tests, I might get the wrong result if the node already had it in the store from a previous test.
I tried doing a garbage collection pass on the datastore after each test, but you have to take the node offline first, and I was getting weird connection reset errors. So I figured I'd just make sure that all the data objects had a random component, so there's no chance of a duplicate object throwing things off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, that makes sense
8521f57
to
ad8e07e
Compare
…ents & objects after test
ad8e07e
to
fe46bd6
Compare
This is basically working, but there's a few missing pieces:
I need to look through this some more tomorrow to make sure I'm not forgetting anything; I can't see the forest for the trees at the moment :)