Use temp file for statement db to avoid connection timeout issues #165
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that knex's connection pool doesn't like in-memory sqlite databases. It's configured to release a connection after an idle timeout, but reopening a connection to
:memory:
creates a new, empty database. The result is that our unit tests all pass, since they complete before the 30 second timeout, but actually trying to use the db at the repl results in your data getting erased (unless you're an especially fast typist 馃槃)This just creates a temporary file with the
node-temp
module and uses it instead of:memory:
. I set up node-temp to track and remove temp files at process exit, so we shouldn't be cluttering up the temp directory.