Skip to content

Commit

Permalink
Emergency Bugfix 4.2.13 (#2697)
Browse files Browse the repository at this point in the history 
* Undo changes introduced 4.2.11 to fix unmute bug

*  added missing target build/renderers/youtube.js in Gruntfile.js

* add build/* for 4.2.13 release
  • Loading branch information
@karawitan
karawitan committed Sep 26, 2019
1 parent 69f931b commit 9993131
Show file tree
Hide file tree
Showing 19 changed files with 1,975 additions and 205 deletions.
1 change: 1 addition & 0 deletions Gruntfile.js
View file
Expand Up @@ -107,6 +107,7 @@ module.exports = function (grunt) {
'build/renderers/facebook.js': 'src/js/renderers/facebook.js',
'build/renderers/soundcloud.js': 'src/js/renderers/soundcloud.js',
'build/renderers/twitch.js': 'src/js/renderers/twitch.js',
'build/renderers/youtube.js': 'src/js/renderers/youtube.js',
'build/renderers/vimeo.js': 'src/js/renderers/vimeo.js'
},
options: {
Expand Down

3 comments on commit 9993131

@OlivierJaquemet
Copy link
Contributor

@OlivierJaquemet OlivierJaquemet commented on 9993131 Sep 26, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Berryamin I think you forgot to update the version number :
https://github.com/mediaelement/mediaelement/blob/4.2.13/src/js/core/mejs.js#L9

Also, it seems other things have been changed, but are not mentionned in the change log

  • youtube renderer added ? [edit it IS mentionned in the commit, not in the change log]
  • I see new comment in the src which were not in the previous version ("cached from whatever global is present so that test runner",) is it just a change in the build process or maybe something else ?

edit : the unedited change log :
https://github.com/mediaelement/mediaelement/blob/4.2.13/changelog.md

Thanks !

@karawitan
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OlivierJaquemet many thanks for the feedback. Indeed, yes, once again I missed the step "update the release number in source code" ... grr. I think the only clean way now is to publish a new version, isn't it ?
I'll take care about the Changelog, good point also.
I have to take care about npmjs.com also, but still fighting with 2FA due to unappropriate phone ..
I wanted to amend commit message for 69f931b, as well .. but it still appears as is ..

@OlivierJaquemet
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately I think it requires indeed a new release :/
Though i'm not familiar enough with the build process to know for sure.

Please sign in to comment.