Fixed typo when destroying window events

mediaelement · Jun 16, 2017 · a46180d · a46180d
1 parent fd7dd9e
commit a46180d
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 5 deletions.
diff --git a/build/mediaelement-and-player.js b/build/mediaelement-and-player.js
@@ -4625,7 +4625,7 @@ var MediaElementPlayer = function () {
 				}
 			}
 			if (events.w) {
-				var _eventList2 = events.d.split(' ');
+				var _eventList2 = events.w.split(' ');
 				for (var _i3 = 0, _total3 = _eventList2.length; _i3 < _total3; _i3++) {
 					_eventList2[_i3].split('.').reduce(function (part, e) {
 						_window2.default.removeEventListener(e, callback, false);

diff --git a/build/mediaelement-and-player.min.js b/build/mediaelement-and-player.min.js
diff --git a/build/mediaelementplayer.js b/build/mediaelementplayer.js
@@ -4625,7 +4625,7 @@ var MediaElementPlayer = function () {
 				}
 			}
 			if (events.w) {
-				var _eventList2 = events.d.split(' ');
+				var _eventList2 = events.w.split(' ');
 				for (var _i3 = 0, _total3 = _eventList2.length; _i3 < _total3; _i3++) {
 					_eventList2[_i3].split('.').reduce(function (part, e) {
 						_window2.default.removeEventListener(e, callback, false);

diff --git a/build/mediaelementplayer.min.js b/build/mediaelementplayer.min.js
diff --git a/changelog.md b/changelog.md
@@ -14,6 +14,7 @@
 * Replacing `buffer` querySelector with getter function in player (https://github.com/mediaelement/mediaelement/pull/2284) @ychen022
 * Fixed issue with keyboard not picking events on Chrome @rafa8626
 * Use flex-box to reduce calculation via Javascript on control bar (https://github.com/mediaelement/mediaelement/pull/2261) @marcobiedermann and @rafa8626
+* Fixed issue with events not being unbound when player is destroyed @rafa8626
 
 *4.1.3 (2017/06/06)*
 

diff --git a/src/js/player.js b/src/js/player.js
@@ -1526,7 +1526,7 @@ class MediaElementPlayer {
 			}
 		}
 		if (events.w) {
-			const eventList = events.d.split(' ');
+			const eventList = events.w.split(' ');
 			for (let i = 0, total = eventList.length; i < total; i++) {
 				eventList[i].split('.').reduce(function (part, e) {
 					window.removeEventListener(e, callback, false);