Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No effect in IE8 #1054

Closed
shuxge opened this issue Dec 16, 2013 · 18 comments
Closed

No effect in IE8 #1054

shuxge opened this issue Dec 16, 2013 · 18 comments

Comments

@shuxge
Copy link

shuxge commented Dec 16, 2013

I thought it was my problem, but I use your demos ... still the same does not work, I hope to be resolved

@FlashJunior
Copy link

@johndyer see also #1040 #987 #1024

@johndyer
Copy link
Collaborator

Yes, there are multiple IE8 error reports, and I'm checking if it's a VM issue or a real issue with IE8 since I can't replicate it on my VM

@FlashJunior
Copy link

see also #1061. there you can see combinations where we have problems. let me know if i can test something for you.

@FlashJunior
Copy link

any update?

@shuxge
Copy link
Author

shuxge commented Jan 9, 2014

no

@johndyer
Copy link
Collaborator

johndyer commented Jan 9, 2014

Were either of you guys able to find a previous version of MediaElement.js that worked with your particular IE8/Flash/VM combination?

On Jan 8, 2014, at 6:51 AM, Martin Bommeli notifications@github.com wrote:

any update?


Reply to this email directly or view it on GitHub.

@andrejpavlovic
Copy link

I had a similar issue and what I noticed was that the "embed" tag was being used instead of the "object" to embed the flash file. Then I looked at the IE detection code and it seems that IE is not being detected correctly.

t.isIE = (nav.appName.toLowerCase().match(/trident/gi) !== null);

"trident" is usually found in the user-agent string, not the appName from what I understand. So I changed the above line of code to:

t.isIE = (ua.match(/trident/gi) !== null);

And the video and video controls started working in IE8 just fine.

@FlashJunior
Copy link

@johndyer
if you compere 2.13.0...2.13.1 you see there was a change from
t.isIE = (nav.appName.toLowerCase().indexOf("microsoft") != -1);
to
t.isIE = (nav.appName.toLowerCase().match(/trident/gi) !== null);

there is a comment from 5months ago from @jefferyto what could help.
t.isIE = (nav.appName.match(/microsoft/gi) !== null) || (ua.match(/trident/gi) !== null);

@jefferyto
Copy link
Contributor

@FlashJunior I opened a pull request (#1018) that was merged about 2 months ago. Perhaps you can try testing the latest version from master (if you haven't already)?

@FlashJunior
Copy link

@jefferyto but if you look @ https://github.com/johndyer/mediaelement/blob/master/build/mediaelement-and-player.js in the master you see just t.isIE = (nav.appName.toLowerCase().match(/trident/gi) !== null);

@jefferyto
Copy link
Contributor

@FlashJunior The files in build are built from files in src. If you clone the repo on your local machine and run src/Builder.py (you'll need Python and Java installed), the files in build should be updated.

@FlashJunior
Copy link

ah, i see. in https://github.com/johndyer/mediaelement/blob/master/src/js/me-featuredetection.js is en other detection. so @johndyer should update the build folder :-/

@johndyer
Copy link
Collaborator

Yes. I only update the build folder when a release is done. I haven't been able to do this until the IE8 issue is 100% resolved.

JD

On Jan 16, 2014, at 1:23 AM, Martin Bommeli notifications@github.com wrote:

ah, i see. in https://github.com/johndyer/mediaelement/blob/master/src/js/me-featuredetection.js is en other detection. so @johndyer should update the build folder :-/


Reply to this email directly or view it on GitHub.

@FlashJunior
Copy link

@johndyer if you like i can test for you with an old win XP IE8 where i get the errors on 2.13.1 version. Send me the compiled version to fj@flashjunior.ch

@johndyer
Copy link
Collaborator

@FlashJunior Just checking here as well. My IE8 works with video on http://www.onebyte.ch/preview/mediaelementjs/v2_13_0/demo/mediaelementplayer.html but I'm still getting a strange error on the audio. I think it might be my Flash install or the fact that I'm using Flash 12.0

@johndyer
Copy link
Collaborator

Could you try to updated 2.13.2?

@rafa8626 rafa8626 closed this as completed Aug 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants