Fixed IE detection #1018
Merged
Fixed IE detection #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navigator.appName is still "Microsoft Internet Explorer" for IE6-10, and "Netscape" for IE11 (so I'm told [1]), neither of which contains "trident". Instead, combine the older "microsoft" match (which still works for IE<11) with a test for "trident" on the user agent string. [1] http://stackoverflow.com/a/17907562
Closed
rexblack
pushed a commit
to rexblack/mediaelement
that referenced
this pull request
May 22, 2014
Fixed IE detection
ale-grosselle
pushed a commit
to ale-grosselle/mediaelement
that referenced
this pull request
Nov 25, 2016
Fixed IE detection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
navigator.appName is still "Microsoft Internet Explorer" for IE6-10, and "Netscape" for IE11 (so I'm told [1]), neither of which contains "trident".
Instead, combine the older "microsoft" match (which still works for IE<11) with a test for "trident" on the user agent string.
[1] http://stackoverflow.com/a/17907562