-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replay button #1067
Comments
@albell Also consider this when you work on the theme, since it is a default behavior on many players nowadays. If you have it sorted out, I'll hook the functionality to display it |
@albell Can you please check the branch |
Should a replay button go in the bottom left of the control bar a la current Youtube, or superimposed over the video? Youtube uses the main space now to signal the next video slated to play. Similar to Vimeo "up next". But Vimeo still also puts a replay button as an overlay. Thoughts? |
I based this on YouTube player, and it doesn't use an overlay; we could add it as part of the Play overlay, but I don't know if it will be too much to have the icon and the overlay. |
@albell If nothing else to add, can I integrate what I have in 3.x-dev branch and close this issue? |
I rebuilt the icons and merged the bigplay.png and loading.gifs into one file here on #1964. Hopefully that'll make things like this easier. |
@johndyer I added the button in the |
Closing issue since button is now part of 3.x-dev |
@johndyer file type nit: Could bigplay.png be an svg? I would really like to steer towards all-vector images if possible, for reasons of file size but also for resolution-independence. My understanding is the project is assuming support for svg-as-img as of v3.0. |
The only PNGs we have is a sprite that matches the new SVG sprite just in case somebody wants to use them |
Got it. Thx |
What about a replay button at the end of a video? Just a thought, it would be quite helpful I think. The loop is a bit weird because it is displayed the whole time and then continuously replays the video. Just a thought though, a bit like how youtube does it.
The text was updated successfully, but these errors were encountered: