Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replay button #1067

Closed
ghost opened this issue Dec 30, 2013 · 13 comments
Closed

Replay button #1067

ghost opened this issue Dec 30, 2013 · 13 comments
Assignees

Comments

@ghost
Copy link

ghost commented Dec 30, 2013

What about a replay button at the end of a video? Just a thought, it would be quite helpful I think. The loop is a bit weird because it is displayed the whole time and then continuously replays the video. Just a thought though, a bit like how youtube does it.

@rafa8626
Copy link
Contributor

rafa8626 commented Oct 1, 2016

@albell Also consider this when you work on the theme, since it is a default behavior on many players nowadays. If you have it sorted out, I'll hook the functionality to display it

@rafa8626 rafa8626 removed the 3.0 label Oct 11, 2016
@rafa8626 rafa8626 self-assigned this Oct 27, 2016
rafa8626 pushed a commit that referenced this issue Dec 13, 2016
@rafa8626
Copy link
Contributor

@albell Can you please check the branch various-fixes to confirm this was integrated properly, please?

@rafa8626 rafa8626 removed the Feature label Dec 13, 2016
@albell
Copy link
Contributor

albell commented Dec 13, 2016

Should a replay button go in the bottom left of the control bar a la current Youtube, or superimposed over the video? Youtube uses the main space now to signal the next video slated to play. Similar to Vimeo "up next". But Vimeo still also puts a replay button as an overlay. Thoughts?

@rafa8626
Copy link
Contributor

I based this on YouTube player, and it doesn't use an overlay; we could add it as part of the Play overlay, but I don't know if it will be too much to have the icon and the overlay.

@rafa8626
Copy link
Contributor

@albell If nothing else to add, can I integrate what I have in 3.x-dev branch and close this issue?

@johndyer
Copy link
Collaborator

I rebuilt the icons and merged the bigplay.png and loading.gifs into one file here on #1964. Hopefully that'll make things like this easier.

rafa8626 pushed a commit that referenced this issue Dec 15, 2016
@rafa8626
Copy link
Contributor

@johndyer I added the button in the controls.svg; when you re-create the PR, consider that button as well. Thanks.

@rafa8626
Copy link
Contributor

Closing issue since button is now part of 3.x-dev

@albell
Copy link
Contributor

albell commented Dec 15, 2016

@johndyer file type nit: Could bigplay.png be an svg? I would really like to steer towards all-vector images if possible, for reasons of file size but also for resolution-independence. My understanding is the project is assuming support for svg-as-img as of v3.0.

@rafa8626
Copy link
Contributor

@albell I just pushed the PR from @johndyer. Now we'll use new SVG sprite and preserving the other for backward compatibility. The PNG files are there but they are not used at all in our stylesheet. If any users wants to support old browsers, they could use that in their own custom stylesheet

@rafa8626
Copy link
Contributor

rafa8626 commented Dec 15, 2016

@johndyer and @albell The "legacy" stylesheet also uses the new control bar styles and the old PNGs and GIF are now removed completely. Just FYI

@rafa8626
Copy link
Contributor

The only PNGs we have is a sprite that matches the new SVG sprite just in case somebody wants to use them

@albell
Copy link
Contributor

albell commented Dec 16, 2016

Got it. Thx

rafa8626 added a commit that referenced this issue Jan 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants