Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

need to add preload attribute for mozilla #2114

Closed
astr0junk opened this issue Mar 3, 2017 · 5 comments
Closed

need to add preload attribute for mozilla #2114

astr0junk opened this issue Mar 3, 2017 · 5 comments
Labels
Needs verification

Comments

@astr0junk
Copy link

I find a little bug in Mozilla FF (41-50 versions). if Audio tag have no preload attribute audio events lifecycle are broken. Html5 will not trigger canplay event while javascript trigger 'play' event programmaticly.

so i think we must add workaround for this situation.
@rafa8626 rafa8626 mentioned this issue Mar 3, 2017
Merged
@rafa8626
Copy link
Contributor

rafa8626 commented Mar 3, 2017 •
edited

If they don't have a preload we can add it by default to none; would that work?

@rafa8626
Copy link
Contributor

rafa8626 commented Mar 3, 2017

I tested this on FF 50 using Browserstack and I couldn't find any issues. Is this something related to the Flash shims only?

@astr0junk
Copy link
Author

Preload none will works. We found this bug in 43 version. Some users says that it can be in 50-51. It's not reliable information.

@rafa8626
Copy link
Contributor

rafa8626 commented Mar 3, 2017

Ok I'll add it soon. Thanks for reporting this.

rafa8626 added a commit that referenced this issue Mar 3, 2017
@rafa8626
Added default preload element if not set on video or audio due …
ec6f86d 
…to issue described on #2114
@rafa8626
Copy link
Contributor

rafa8626 commented Mar 3, 2017

The feature was added. Thanks for reporting this. Closing issue

@rafa8626 rafa8626 closed this as completed Mar 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs verification
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rafa8626 @astr0junk