remove method does not cleanup mejs.players array #670
Comments
|
Any suggestions on how to fix this one? I might be up for trying a patch? |
msgilligan
added a commit
to msgilligan/mediaelement
that referenced
this issue
Feb 26, 2013
* SpecRunner-Player runs some basic tests on the player * SpecRunner-CreateRemove tests for Issue mediaelement#670 Note: the tests run directly on the individual .js files rather than on the catenated or minified files. That could be easily changed, but it's nice to be able to run a test, make a fix, and just reload the browser.
phuongdh
pushed a commit
to avalonmediasystem/mediaelement
that referenced
this issue
Oct 18, 2013
* SpecRunner-Player runs some basic tests on the player * SpecRunner-CreateRemove tests for Issue mediaelement#670 Note: the tests run directly on the individual .js files rather than on the catenated or minified files. That could be easily changed, but it's nice to be able to run a test, make a fix, and just reload the browser.
rexblack
pushed a commit
to rexblack/mediaelement
that referenced
this issue
May 22, 2014
* SpecRunner-Player runs some basic tests on the player * SpecRunner-CreateRemove tests for Issue mediaelement#670 Note: the tests run directly on the individual .js files rather than on the catenated or minified files. That could be easily changed, but it's nice to be able to run a test, make a fix, and just reload the browser.
rexblack
pushed a commit
to rexblack/mediaelement
that referenced
this issue
May 22, 2014
* SpecRunner-Player runs some basic tests on the player * SpecRunner-CreateRemove tests for Issue mediaelement#670 Note: the tests run directly on the individual .js files rather than on the catenated or minified files. That could be easily changed, but it's nice to be able to run a test, make a fix, and just reload the browser.
|
This is now working in version 2.16.2 (might be fixed in previous versions as well) |
marmite22
pushed a commit
to elucidat/mediaelement
that referenced
this issue
Dec 16, 2016
* SpecRunner-Player runs some basic tests on the player * SpecRunner-CreateRemove tests for Issue mediaelement#670 Note: the tests run directly on the individual .js files rather than on the catenated or minified files. That could be easily changed, but it's nice to be able to run a test, make a fix, and just reload the browser.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The issue is fully explained in this stackoverflow post.
When you call
player.remove(), themejs.playersarray still contains a reference to the removed player, so if you create a new player from the same video tag, you end up with two entries inmejs.playerswhere you sould have only one.The solution could be to call
mejs.players.slice(index)with the goodindexvalue in theremove()method.The text was updated successfully, but these errors were encountered: