Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Make setPoster work on mobile devices with native controls #2419

Merged

Conversation

lucash
Copy link
Contributor

@lucash lucash commented Oct 10, 2017

This fixes #2418.
If an mobile device is used and mediaelement is configured to use native
controls in this case, t.container is not defined. Therefore the
setPoster() method threw an error.
In that case now the poster attribute is used, which is the native way
of showing the poster image.

This fixes mediaelement#2418.
If an mobile device is used and mediaelement is configured to use native
controls in this case, t.container is not defined. Therefore the
setPoster() method threw an error.
In that case now the poster attribute is used, which is the native way
of showing the poster image.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 73.832% when pulling 7d4781b on lucash:fix-ios-native-controls-setposter into be2e7e8 on mediaelement:master.

@lucash
Copy link
Contributor Author

lucash commented Oct 10, 2017

@rafa8626
This potentially conflicts with #2312. As I wasn't able to reproduce that issue I was not able to make sure that it is not a problem. Regarding the comment in code, removing the attribute helps if you need to support iOS 3.x - maybe it is needed to suppress setting the attribute for that iOS version? I think using a poster image should not be avoided at all if an iOS device is used with native controls as current iOS versions seem to support it.

@rafa8626
Copy link
Contributor

@lucash Thanks for your PR. At this point, we only support iOS 8 and and above, so the comment for that is invalid

@rafa8626
Copy link
Contributor

I'll review your PR as soon as I can, unless you are gonna modify it based on your comment above. Let me know if it's ready to review. Thanks

@lucash
Copy link
Contributor Author

lucash commented Oct 10, 2017

Please review. As I'm not able to reproduce above issue I won't change anything.

@rafa8626 rafa8626 merged commit 7d4781b into mediaelement:master Oct 10, 2017
@rafa8626
Copy link
Contributor

PR merged. Thanks and please star the project to support it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS with native controls: setPoster() leads to error
3 participants