Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DFXP parsing: remove remnants of jQuery use #2760

Merged
merged 1 commit into from Apr 5, 2020
Merged

Fix DFXP parsing: remove remnants of jQuery use #2760

merged 1 commit into from Apr 5, 2020

Conversation

rkrusenb
Copy link
Contributor

@rkrusenb rkrusenb commented Apr 2, 2020 •
edited

DFXP subtitle track parsing has been broken roughly 3 years. This aims to fix this.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 74.487% when pulling e61d690 on rkrusenb:fix/dfxp-parsing into 80b658f on mediaelement:master.

karawitan
karawitan approved these changes Apr 5, 2020
View reviewed changes
Copy link
Collaborator

@karawitan karawitan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much !

@karawitan karawitan merged commit 06135fc into mediaelement:master Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karawitan karawitan karawitan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rkrusenb @coveralls @karawitan