Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issues with fullscreen under Safari #2762

Merged
merged 1 commit into from
Apr 17, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/js/features/fullscreen.js
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ Object.assign(MediaElementPlayer.prototype, {

// iOS allows playing fullscreen ONLY on `video` tag, so check if the source can go fullscreen on iOS
// and if the player can play the current source
if (t.options.useFakeFullscreen === false && Features.IS_IOS && Features.HAS_IOS_FULLSCREEN &&
if (t.options.useFakeFullscreen === false && (Features.IS_IOS || Features.IS_SAFARI) && Features.HAS_IOS_FULLSCREEN &&
typeof t.media.originalNode.webkitEnterFullscreen === 'function' &&
t.media.originalNode.canPlayType(getTypeFromFile(t.media.getSrc()))) {
t.media.originalNode.webkitEnterFullscreen();
Expand Down