Volume handle doesn't set initial position properly #625
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The volume handle must be visible when its position is set, but
secondTry
isn't detected due to the wrong operator being used in a boolean statement:In the above code, it should check to see if
typeof secondTry === 'undefined'
.I have also rounded height/width/position of the volume handle and currents - if they're not rounded, they can be seen off by a pixel at times. Also, jQuery rounds improperly upon calling
.top
,.width
or.height
insidehandleVolumeMove
.