Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume handle doesn't set initial position properly #625

Merged
merged 3 commits into from
Nov 15, 2012

Conversation

JeffreyATW
Copy link
Contributor

The volume handle must be visible when its position is set, but secondTry isn't detected due to the wrong operator being used in a boolean statement:

if (!volumeSlider.is(':visible') && typeof secondTry != 'undefined') {
    volumeSlider.show();
    positionVolumeHandle(volume, true);
    volumeSlider.hide()
    return;
}

In the above code, it should check to see if typeof secondTry === 'undefined'.

I have also rounded height/width/position of the volume handle and currents - if they're not rounded, they can be seen off by a pixel at times. Also, jQuery rounds improperly upon calling .top, .width or .height inside handleVolumeMove.

johndyer added a commit that referenced this pull request Nov 15, 2012
Volume handle doesn't set initial position properly
@johndyer johndyer merged commit 884a94a into mediaelement:master Nov 15, 2012
phuongdh pushed a commit to avalonmediasystem/mediaelement that referenced this pull request Oct 18, 2013
Volume handle doesn't set initial position properly
rexblack pushed a commit to rexblack/mediaelement that referenced this pull request May 22, 2014
Volume handle doesn't set initial position properly
rexblack pushed a commit to rexblack/mediaelement that referenced this pull request May 22, 2014
Volume handle doesn't set initial position properly
marmite22 pushed a commit to elucidat/mediaelement that referenced this pull request Dec 16, 2016
Volume handle doesn't set initial position properly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants